Skip to content

Conversation

@annevk
Copy link
Member

@annevk annevk commented Jun 16, 2023

This builds on whatwg/dom#1210 and together they fix #9390.


/form-elements.html ( diff )
/infrastructure.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although tests would probably be a good idea? @dbaron might also want to take a look.

annevk added 2 commits August 25, 2023 12:20
This builds on whatwg/dom#1210 and together they fix #9390.
@annevk annevk force-pushed the annevk/optgroup-removal branch from f28592e to 51ef454 Compare August 25, 2023 10:21
@annevk annevk merged commit aceb2e3 into main Aug 25, 2023
@annevk annevk deleted the annevk/optgroup-removal branch August 25, 2023 10:54
@annevk
Copy link
Member Author

annevk commented Aug 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

issues with optionality of oldParent in HTML element removing steps, particularly with removal of optgroups

3 participants