Skip to content

Remove callerRealm from HostEnsureCanCompileStrings#7653

Merged
annevk merged 1 commit intowhatwg:mainfrom
antosart:remove-caller-realm
Apr 22, 2022
Merged

Remove callerRealm from HostEnsureCanCompileStrings#7653
annevk merged 1 commit intowhatwg:mainfrom
antosart:remove-caller-realm

Conversation

@antosart
Copy link
Copy Markdown
Member

@antosart antosart commented Feb 23, 2022 •
edited by pr-preview bot
Loading

This PR removes the parameter callerRealm from HostEnsureCanCompileStrings. The parameter was sent to EnsureCSPDoesNotBlockStringCompilation in CSP, which however does not use that parameter (the parameter is being removed there, too, see w3c/webappsec-csp#541).

This change is a no-op, so I believe the following does not apply.

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chrome: …
    • Firefox: …
    • Safari: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …

(See WHATWG Working Mode: Changes for more details.)

/index.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )

This was referenced Feb 23, 2022
Merged
Merged
@antosart antosart requested a review from annevk February 23, 2022 10:47
@antosart
Copy link
Copy Markdown
Member Author

antosart commented Feb 23, 2022

The companion PR on ECMAScript is tc39/ecma262#2670.

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Feb 23, 2022
@domenic
Copy link
Copy Markdown
Member

domenic commented Feb 23, 2022

Tagging "do not merge yet" until the 262 PR is merged.

(Note, if they don't want to merge it in 262, then we can adapt this PR to just not pass the second realm to CSP.)

@antosart
Copy link
Copy Markdown
Member Author

antosart commented Apr 22, 2022

tc39/ecma262#2670 is merged, so we should be good to go here.

In tc39/ecma262#2670 it was suggested to rename calleeRealm into something more neutral, like currentRealm. I have no strong preference here, but I am happy to change this.

@annevk
Copy link
Copy Markdown
Member

annevk commented Apr 22, 2022

Maybe we should call it realm?

The weird thing is that "callee" isn't referring to HostEnsureCanCompileStrings, but rather to the caller of HostEnsureCanCompileStrings.

@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Apr 22, 2022
@antosart antosart force-pushed the remove-caller-realm branch from 754859d to e0c1a94 Compare April 22, 2022 08:18
@antosart
Copy link
Copy Markdown
Member Author

antosart commented Apr 22, 2022

Makes sense. I renamed it realm.

@annevk annevk merged commit fecc699 into whatwg:main Apr 22, 2022
@annevk
Copy link
Copy Markdown
Member

annevk commented Apr 22, 2022

Thanks @antosart for making the cleanup happen across all these repositories, this is a lot better.

@antosart antosart deleted the remove-caller-realm branch April 22, 2022 09:06
@antosart antosart mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antosart @domenic @annevk