Treat javascript: URL results as UTF-8 bytes#6781
Merged
Conversation
Member
Author
|
No, wait, this doesn't match Chrome I think... let's continue discussion in #1129. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 16, 2021
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 17, 2021
Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from #29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2021
Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from #29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2021
Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from #29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#893876}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2021
Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from #29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#893876}
Member
|
Chrome now matches this PR fully after https://crrev.com/c/2967353 (Chrome 93). |
annevk
approved these changes
Jun 22, 2021
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Yeah, this still seems like a good idea.
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2021
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2021
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 27, 2021
…ting javascript URLs, a=testonly Automatic update from web-platform-tests Replace unpaired surrogates after evaluating javascript URLs Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from web-platform-tests/wpt#29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#893876} -- wpt-commits: ad7af3947f19693e8ab8911663a41152e907ed0e wpt-pr: 29422
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 27, 2021
…rsion tests, a=testonly Automatic update from web-platform-tests Un-.tentative javascript: byte handling test whatwg/html#6781 got merged. -- wpt-commits: 4465a5d5ffb1b89a7f9960fb614da2317c63e860 wpt-pr: 29419
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 16, 2021
…ting javascript URLs, a=testonly Automatic update from web-platform-tests Replace unpaired surrogates after evaluating javascript URLs Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from web-platform-tests/wpt#29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#893876} -- wpt-commits: ad7af3947f19693e8ab8911663a41152e907ed0e wpt-pr: 29422
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 16, 2021
…rsion tests, a=testonly Automatic update from web-platform-tests Un-.tentative javascript: byte handling test whatwg/html#6781 got merged. -- wpt-commits: 4465a5d5ffb1b89a7f9960fb614da2317c63e860 wpt-pr: 29419
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Oct 27, 2021
https://bugs.webkit.org/show_bug.cgi?id=232380 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that more checks are passing. The remaining failures are due to the fact that we ignore the JavaScript URL result when the URL is set as href on an anchor (as opposed to the src of an iframe). This will be addressed separately. * web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic-expected.txt: Source/WebCore: JavaScript URL result should be treated as UTF-8 bytes: - whatwg/html#6781 No new tests, rebaselined existing test. * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocumentWithResultOfExecutingJavascriptURL): Canonical link: https://commits.webkit.org/243604@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
philn
pushed a commit
to philn/old-webkit
that referenced
this pull request
Nov 3, 2021
https://bugs.webkit.org/show_bug.cgi?id=232380 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that more checks are passing. The remaining failures are due to the fact that we ignore the JavaScript URL result when the URL is set as href on an anchor (as opposed to the src of an iframe). This will be addressed separately. * web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic-expected.txt: Source/WebCore: JavaScript URL result should be treated as UTF-8 bytes: - whatwg/html#6781 No new tests, rebaselined existing test. * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocumentWithResultOfExecutingJavascriptURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@284934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…ting javascript URLs, a=testonly Automatic update from web-platform-tests Replace unpaired surrogates after evaluating javascript URLs Given a URL like javascript:String.fromCodePoint(0xDE0D), Chrome currently displays three U+FFFD replacement characters rather than just one, due to the incorrect UTF-8 conversion mode. We fix that by using kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD. This CL fully implements whatwg/html#6781. Tests are partially taken from web-platform-tests/wpt#29419. Co-authored-by: Domenic Denicola <[email protected]> Bug: 1221018 Change-Id: Ic1282d0a88eabb40b4d5d8d8c68e040e9a0a938d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967353 Commit-Queue: Timothy Gu <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/master@{#893876} -- wpt-commits: ad7af3947f19693e8ab8911663a41152e907ed0e wpt-pr: 29422
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…rsion tests, a=testonly Automatic update from web-platform-tests Un-.tentative javascript: byte handling test whatwg/html#6781 got merged. -- wpt-commits: 4465a5d5ffb1b89a7f9960fb614da2317c63e860 wpt-pr: 29419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1129.
(See WHATWG Working Mode: Changes for more details.)
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jun 22, 2021, 5:09 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.