Conversation
TRowbotham
added a commit
to TRowbotham/PHPDOM
that referenced
this pull request
Apr 1, 2021
Fixes html tags being nested inside svg and math tags. Uses the proposed spec changes from whatwg/html#6399 and whatwg/html#6455
3 tasks
Member
|
@zcorpan am I correct that this is already implemented in Chrome and Safari? In that case we have implementer interest and should merge this. |
domenic
approved these changes
Jul 16, 2021
Member
Author
|
Yes. It's implemented in Gecko as well, in that it will also foster parent the |
stevecheckoway
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Oct 13, 2021
The first comment is incorrect. The fragment case was changed to match the nonfragment case in whatwg/html#6399. This introduced a bug that was noted by the second comment indicating that the parser diverged from the standard to fix the bug. The standard was subsequently fixed in whatwg/html#6455, obviating the comment.
fb55
added a commit
to inikulin/parse5
that referenced
this pull request
Mar 13, 2022
The behaviour for parsing foreign content was updated in whatwg/html#6455 and whatwg/html#6736. This catches us up to the current specced behaviour.
txgk
added a commit
to gumbo-parser/gumbo-parser
that referenced
this pull request
Aug 26, 2025
with this change 17 more tests from html5lib-tests are passing whatwg/html#6399 whatwg/html#6455 sparklemotion/nokogiri@b317bb8 sparklemotion/nokogiri@e4b29a4 sparklemotion/nokogiri@9727445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression was introduced in f690ad9
(PR #6399)
For this case:
the
<p>token would not have foster parenting enabled, thus inserting itinto the table.
Fixes #6439.
(See WHATWG Working Mode: Changes for more details.)
/parsing.html ( diff )