Skip to content

Disallow import() in worklets#6070

Merged
domenic merged 1 commit intomasterfrom
worklet-dynamic-import
Oct 19, 2020
Merged

Disallow import() in worklets#6070
domenic merged 1 commit intomasterfrom
worklet-dynamic-import

Conversation

@domenic
Copy link
Copy Markdown
Member

@domenic domenic commented Oct 16, 2020

Closes w3c/css-houdini-drafts#506.

(See WHATWG Working Mode: Changes for more details.)


/webappapis.html ( diff )

@annevk
Copy link
Copy Markdown
Member

annevk commented Oct 19, 2020

@padenot do you know if we have tests for this for audio worklets?

Copy link
Copy Markdown
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially looks good. Glad it's as simple as this.

@padenot
Copy link
Copy Markdown

padenot commented Oct 19, 2020

* I suspect this is what Firefox implements too; @annevk at least was supportive, in [w3c/css-houdini-drafts#506](https://github.com/w3c/css-houdini-drafts/issues/506)

I confirm this.

@nhiroki
Copy link
Copy Markdown
Contributor

nhiroki commented Oct 19, 2020

I double-checked this spec change is aligned with Chrome implementation.

For testing on WPTs, I have no ideas other than using API specific features ("Awkward communication") like postMessage() for audio worklets and coloring <div> for paint worklets.

@domenic
Copy link
Copy Markdown
Member Author

domenic commented Oct 19, 2020

I added a basic paint worklet test in web-platform-tests/wpt#26175. Any review is appreciated. I don't feel comfortable writing a test for audio worklets because they seem to use some nonstandard test harness.

domenic added a commit to web-platform-tests/wpt that referenced this pull request Oct 19, 2020
@domenic domenic merged commit de47fa3 into master Oct 19, 2020
@domenic domenic deleted the worklet-dynamic-import branch October 19, 2020 16:56
@padenot
Copy link
Copy Markdown

padenot commented Oct 20, 2020

I don't feel comfortable writing a test for audio worklets because they seem to use some nonstandard test harness.

You can also use the standard harness in the normal way.

domenic added a commit to web-platform-tests/wpt that referenced this pull request Dec 10, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 17, 2020
… in paint worklets, a=testonly

Automatic update from web-platform-tests
Test that dynamic import() is disallowed in paint worklets

Follows whatwg/html#6070.
--

wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7
wpt-pr: 26175
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Dec 18, 2020
… in paint worklets, a=testonly

Automatic update from web-platform-tests
Test that dynamic import() is disallowed in paint worklets

Follows whatwg/html#6070.
--

wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7
wpt-pr: 26175

UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Dec 18, 2020
… in paint worklets, a=testonly

Automatic update from web-platform-tests
Test that dynamic import() is disallowed in paint worklets

Follows whatwg/html#6070.
--

wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7
wpt-pr: 26175

UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Dec 18, 2020
… in paint worklets, a=testonly

Automatic update from web-platform-tests
Test that dynamic import() is disallowed in paint worklets

Follows whatwg/html#6070.
--

wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7
wpt-pr: 26175

UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
sidvishnoi pushed a commit to sidvishnoi/gecko-webmonetization that referenced this pull request Dec 24, 2020
… in paint worklets, a=testonly

Automatic update from web-platform-tests
Test that dynamic import() is disallowed in paint worklets

Follows whatwg/html#6070.
--

wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7
wpt-pr: 26175
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
… in paint worklets, a=testonly

Automatic update from web-platform-tests
Test that dynamic import() is disallowed in paint worklets

Follows whatwg/html#6070.
--

wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7
wpt-pr: 26175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

[worklets] dynamic import()

4 participants