Skip to content

Remove specification of intrinsic aspect-ratio, and instead map width… #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domenic merged 6 commits into from
Feb 19, 2021
Merged

Remove specification of intrinsic aspect-ratio, and instead map width… #6032

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e41e59b
Remove specification of intrinsic aspect-ratio, and instead map width…
tabatkins Oct 5, 2020
06a898e
Tell Wattsi that the property value isn't a link.
tabatkins Oct 6, 2020
5647ac4
Now that aspect-ratio treats 0 or infinite ratios as an error case, l…
tabatkins Nov 7, 2020
e9dcb08
Make it clear that the parsed number should be a px length.
tabatkins Nov 7, 2020
632c6f4
Specify that the mapping also applies to video, canvas, and image but…
tabatkins Nov 7, 2020
d14efd5
Oh duh, right, aspect ratios are unitless anyway.
tabatkins Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3384,7 +3384,6 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<ul class="brief">
<li><dfn data-x-href="https://drafts.csswg.org/css-images/#default-object-size">default object size</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/css-images/#intrinsic-dimensions">intrinsic dimensions</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/css-images/#intrinsic-aspect-ratio">intrinsic aspect ratio</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/css-images/#intrinsic-height">intrinsic height</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/css-images/#intrinsic-width">intrinsic width</dfn></li>
<li>The <dfn data-x-href="https://drafts.csswg.org/css-images-3/#the-image-orientation">'image-orientation'</dfn> property</li>
Expand Down Expand Up @@ -3477,6 +3476,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute

<ul class="brief">
<li><dfn data-x-href="https://drafts.csswg.org/css-sizing/#fit-content-inline-size">fit-content inline size</dfn></li>
<li><dfn data-x-href="https://drafts.csswg.org/css-sizing-4/#aspect-ratio">'aspect-ratio'</dfn> property</li>
</ul>

<p>The <dfn
Expand Down Expand Up @@ -113077,6 +113077,15 @@ console.assert(container.firstChild instanceof SuperP);
<var>properties</var>, with the value given as a pixel length if the dimension was a length, and
with the value given as a percentage if the dimension was a percentage.</p>

<p>When the text below says that a pair of attributes <var>w</var> and <var>h</var> on an
element <var>element</var> <dfn>map to the aspect-ratio property</dfn>, it means that if
<var>element</var> has both attributes <var>w</var> and <var>h</var>, and parsing those
attributes' values using the <span>rules for parsing nonzero dimension values</span> doesn't
generate an error or return a percentange for either, then the user agent is expected to use the
parsed dimensions as a <span data-x="presentational hints">presentational hint</span> for the
<span>'aspect-ratio'</span> property of the form <code data-x="">auto
<var>w</var> / <var>h</var></code>.</p>

<p>When a user agent is to <dfn>align descendants</dfn> of a node, the user agent is expected to
align only those descendants that have both their <span>'margin-inline-start'</span> and
<span>'margin-inline-end'</span> properties computing to a value other than 'auto', that are
Expand Down Expand Up @@ -114729,22 +114738,11 @@ input[type=image i][align=bottom i], object[align=bottom i] {
property">map to the dimension properties</span> <span>'width'</span> and <span>'height'</span> on
the element respectively.</p>

<p>The <span>intrinsic aspect ratio</span> for an <code>img</code> element <var>img</var> is
computed as follows:</p>

<ol>
<li><p>If <var>img</var>'s <span>current request</span> is <span
data-x="img-available">available</span> and has an <span>intrinsic aspect ratio</span>, then
use that intrinsic aspect ratio.</p></li>

<li><p>If <var>img</var>'s <code data-x="attr-dim-width">width</code> and <code
data-x="attr-dim-height">height</code> attribute values, when parsed using the <span>rules for
parsing dimension values</span>, are both not an error, not a percentage, and non-zero, then use
the ratio resulting from dividing the <code data-x="attr-dim-width">width</code> attribute value
by the <code data-x="attr-dim-height">height</code> attribute value.</p></li>

<li><p>Otherwise, <var>img</var> has no <span>intrinsic aspect ratio</span>.</p></li>
</ol>
<p>The <code data-x="attr-dim-width">width</code> and <code data-x="attr-dim-height">height</code>
attributes <span>map to the aspect-ratio property</span> on <code>img</code>, <code>canvas</code>,
and <code>video</code> elements, and <code>input</code> elements with a <code
data-x="attr-input-type">type</code> attribute in the <span data-x="attr-input-type-image">Image
Button</span> state.
</div>


Expand Down