Editorial: modernization of script fetching algorithms#5774
Merged
Conversation
domenic
force-pushed
the
editorial-tweaks-script-fetching
branch
3 times, most recently
from
88008f4 to
8b8a638
Compare
Use "return" instead of "abort these steps", and don't re-declare variables. Also tweaks the multi-condition checks.
domenic
force-pushed
the
editorial-tweaks-script-fetching
branch
from
8b8a638 to
1bb86dc
Compare
3 tasks
TimothyGu
approved these changes
Aug 2, 2020
vsasvipul0605
approved these changes
Aug 4, 2020
annevk
approved these changes
Aug 5, 2020
| <ul> | ||
| <li><p><var>response</var>'s <span data-x="concept-response-type">type</span> is "<code | ||
| data-x="">error</code>"</p></li> | ||
| data-x="">error</code>"; or</p></li> |
Member
There was a problem hiding this comment.
We typically don't include "or" in these inline lists.
Member
Author
There was a problem hiding this comment.
Yeah, but I did it in this case because the sentence just continues on afterward, so I wanted to make the whole thing sentence-like.
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "return" instead of "abort these steps", and don't re-declare
variables.
Extracted from #5302.
/webappapis.html ( diff )