Add <form>'s "firing submission events" flag#4621
Merged
domenic merged 4 commits intowhatwg:masterfrom May 15, 2019
Merged
Conversation
tkent-google
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 14, 2019
tkent-google
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 14, 2019
Member
|
So reentrancy for the |
domenic
approved these changes
May 14, 2019
source
Outdated
| and probably informed the user of this) then | ||
| <span data-x="concept-event-fire">fire an event</span> named | ||
| <code data-x="event-invalid">invalid</code> at the <var>form</var> element and then return. | ||
| </p></li> |
Member
There was a problem hiding this comment.
Nit: this wrapping introduces an observable space after the period. I will fix.
Also removes comments that are no longer helpful because the structure is now obvious from the actual spec text.
Contributor
Author
Good point! I also found none of Chrome, Firefox and Safari dispatches |
Member
|
Wow, OK. Can you take care of updating this PR and tests? I think it'll make more sense to just land everything together. This would include a -historical test that there is no invalid event fired at the form I guess we should name the boolean "firing submission events" or something since it's also about the invalid events. |
- Rename the flag; firing submit event -> firing submission events
Contributor
Author
|
Updated this PR. Will update the WPT PR. |
Member
|
I guess that's fair. |
tkent-google
changed the title
Member
|
I filed #4626 on |
annevk
approved these changes
May 15, 2019
tkent-google
commented
May 15, 2019
source
Outdated
| <var>form</var> and examine the result: if the result is negative (the constraint validation | ||
| concluded that there were invalid fields and probably informed the user of this) then <span | ||
| data-x="concept-event-fire">fire an event</span> named <code | ||
| data-x="event-invalid">invalid</code> at the <var>form</var> element and then return.</p></li> |
Contributor
Author
There was a problem hiding this comment.
Need to reset the flag here too. I'll update the PR tomorrow.
Member
There was a problem hiding this comment.
I'll update it now so we can merge; I want to rebase #4597 on top.
tkent-google
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2019
Specification change: whatwg/html#4621
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 19, 2019
…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 19, 2019
…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
Specification change: whatwg/html#4621
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811 UltraBlame original commit: b05ea3f35ab4136dd53da0fb0ec41d0819b8a0f7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811 UltraBlame original commit: b05ea3f35ab4136dd53da0fb0ec41d0819b8a0f7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811 UltraBlame original commit: b05ea3f35ab4136dd53da0fb0ec41d0819b8a0f7
5 tasks
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4620
(See WHATWG Working Mode: Changes for more details.)
/form-control-infrastructure.html ( diff )