Make document.open() set the document to no-quirks #3966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per investigation in whatwg#3818, this change aligns the behavior of document.open() with Chrome and Safari. Tests: web-platform-tests/wpt#10679
19 tasks
domenic
approved these changes
Aug 27, 2018
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM
I wonder if we should update the DOM spec:
The mode is only ever changed from the default for documents created by the HTML parser based on the presence, absence, or value of the DOCTYPE string, and by a new browsing context (initial "about:blank"). [HTML]
It's unclear whether this falls under "for documents created by the HTML parser" or not...
Member
Author
|
@domenic The mode wouldn't be "changed from the default" in this PR… if anything it is reverting those changes back to the default. |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 28, 2018
Member
|
I haven't filed bugs since I believe the plan is that we file bugs once #3818 is resolved. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 3, 2018
…=testonly Automatic update from web-platform-testsHTML: document.open() and quirks mode For whatwg/html#3966. -- wpt-commits: 5c0f55eea08d3f00dc761cff4ef1dbb9864bee29 wpt-pr: 10679
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Sep 3, 2018
…=testonly Automatic update from web-platform-testsHTML: document.open() and quirks mode For whatwg/html#3966. -- wpt-commits: 5c0f55eea08d3f00dc761cff4ef1dbb9864bee29 wpt-pr: 10679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per investigation in #3818, this change aligns the behavior of
document.open()with Chrome, Edge, and Safari.Tests: web-platform-tests/wpt#10679