document.open() simplifications: realm creation, unloading, tasks removal #3918

TimothyGu · 2018-08-14T19:08:56Z

Based on the work by Anne van Kesteren in #3651, but without the parts concerning the session history. Changes to that area will come later (see #3818).

Summary of implementation changes:

Chrome and Safari are already fully aligned with this change.
Edge and Firefox both create a new JavaScript realm. They should not do that after this PR.
Edge and Firefox removes some tasks but not others (see No longer remove tasks for document.open() #3665). They should now remove no tasks after this PR.
Firefox fires beforeunload event in document.open() (but not pagehide or unload). It should no longer fire it after this PR.

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes #1698.
Fixes #3286.
Fixes #3306.
Closes #3665.

/cc @bzbarsky @daniec @foolip @travisleithead

/browsers.html ( diff )
/browsing-the-web.html ( diff )
/dynamic-markup-insertion.html ( diff )
/history.html ( diff )
/window-object.html ( diff )

Based on the work by Anne van Kesteren in whatwg#3651, but without the parts concerning the session history. Changes to that area will come later (see whatwg#3818). Tests: web-platform-tests/wpt#10773 Tests: web-platform-tests/wpt#10778 Tests: web-platform-tests/wpt#10815 Tests: web-platform-tests/wpt#10818 Fixes whatwg#1698. Fixes whatwg#3286. Fixes whatwg#3306. Closes whatwg#3665. Co-authored-by: Anne van Kesteren <[email protected]>

domenic

We should update the commit message to reflect that this removes a few separate pieces:

Realm creation
Task removal
Unloading

As discussed in person, there's also some other stuff to remove that references this infrastructure.

I think we'll also want a follow up bug (one may already exist?) on specifically simplifying some stuff now that there's no longer a potential 1:many Document:Window relationship, but I'm forgetting the details of how that worked right now... Will try to recall.

domenic · 2018-08-14T22:52:51Z

source

  <p class="note">In general, there is a 1-to-1 mapping from the <code>Window</code> object to the
  <code>Document</code> object, as long as the <code>Document</code> object has a <span
-  data-x="concept-document-bc">browsing context</span>. There are two exceptions. First, a
+  data-x="concept-document-bc">browsing context</span>. There is one exceptions. A


domenic · 2018-08-14T23:26:18Z

I think we'll also want a follow up bug (one may already exist?) on specifically simplifying some stuff now that there's no longer a potential 1:many Document:Window relationship, but I'm forgetting the details of how that worked right now... Will try to recall.

It looks like the main thing is there's a lot of "document's Window object", which is an underdefined term before this PR. After this PR it can simply become "document's relevant global object".

There's also a lot of "document's Window object's environment settings object" which should just become "document's relevant settings object".

My method for finding these is to use Ctrl+F with the string 's Window on the page.

annevk

Looks good editorially. I think I also sufficiently convinced that @bzbarsky that we should do this, but more tests (and revisions) for the entire document.open() algorithm will be needed for Firefox to take the jump.

domenic

LGTM, let's merge!

Another test to update is https://github.com/web-platform-tests/wpt/blob/34b1111aaf51b0143edcc5e3b454cff680edcd6f/common/object-association.js#L44-L65. We may want to actually flip the condition instead of deleting it.

annevk · 2018-08-16T06:08:28Z

(Really enjoying these additional cleanup commits. Lots of simplifications in complex algorithms.)

TimothyGu · 2018-08-16T21:45:32Z

I've updated the pull request title and I believe this should be ready to merge! I will continue working on the WPT PRs to ensure they are merged.

On the bugs side, I plan on filing a mega-bug for both Edge and Firefox containing this change and some future PRs. As such I don't plan to file a bug for this PR specifically. As states before this PR does not require bugs on Chrome or Safari.

For whatwg/html#3918.

For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <[email protected]>

For whatwg/html#3918.

…nt, a=testonly Automatic update from web-platform-testsHTML: document.open() and the unload events (#10773) For whatwg/html#3918. -- wpt-commits: 23c21d2e0e6a8035ddfab91e33c54103d859ffca wpt-pr: 10773

…ad event, a=testonly Automatic update from web-platform-testsHTML: document.open() and the beforeunload event (#10778) For whatwg/html#3918. -- wpt-commits: eafe4bdb65ced7352e953ec35c06c3afa3d8125b wpt-pr: 10778

…es, a=testonly Automatic update from web-platform-testsHTML: document.open() and global variables (#10815) For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <[email protected]> -- wpt-commits: 70c15a6e508f7460e1584bc8b122ac2cc8f9d6ea wpt-pr: 10815

For whatwg/html#3918.

For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <[email protected]>

For whatwg/html#3918.

Automatic update from web-platform-testsHTML: document.open() and tasks (#10818) For whatwg/html#3918. -- wpt-commits: 87329a1500b1aea8f9cf28b40afb08491e25a5c7 wpt-pr: 10818

For whatwg/html#3918.

…ation, a=testonly Automatic update from web-platform-testsHTML: Change document.open() test expectation (#12882) For whatwg/html#3918. -- wpt-commits: b70ac6309528aacacfaec186478d0b30b018b8f9 wpt-pr: 12882

…nt, a=testonly Automatic update from web-platform-testsHTML: document.open() and the unload events (#10773) For whatwg/html#3918. -- wpt-commits: 23c21d2e0e6a8035ddfab91e33c54103d859ffca wpt-pr: 10773 UltraBlame original commit: 7a308e5f78c2792c423ec0b5d7e6d6bbafdf230a

…ad event, a=testonly Automatic update from web-platform-testsHTML: document.open() and the beforeunload event (#10778) For whatwg/html#3918. -- wpt-commits: eafe4bdb65ced7352e953ec35c06c3afa3d8125b wpt-pr: 10778 UltraBlame original commit: 5e452420d498274a79b91e9a7281f83202066a95

…es, a=testonly Automatic update from web-platform-testsHTML: document.open() and global variables (#10815) For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <timothygu99gmail.com> -- wpt-commits: 70c15a6e508f7460e1584bc8b122ac2cc8f9d6ea wpt-pr: 10815 UltraBlame original commit: bff723cc3832cb0b00fa13a8494ee3aa3bfe74fa

Automatic update from web-platform-testsHTML: document.open() and tasks (#10818) For whatwg/html#3918. -- wpt-commits: 87329a1500b1aea8f9cf28b40afb08491e25a5c7 wpt-pr: 10818 UltraBlame original commit: 06c73a2328c73684f20a24c38a53756f028d66f8

…nt, a=testonly Automatic update from web-platform-testsHTML: document.open() and the unload events (#10773) For whatwg/html#3918. -- wpt-commits: 23c21d2e0e6a8035ddfab91e33c54103d859ffca wpt-pr: 10773 UltraBlame original commit: 7a308e5f78c2792c423ec0b5d7e6d6bbafdf230a

…ad event, a=testonly Automatic update from web-platform-testsHTML: document.open() and the beforeunload event (#10778) For whatwg/html#3918. -- wpt-commits: eafe4bdb65ced7352e953ec35c06c3afa3d8125b wpt-pr: 10778 UltraBlame original commit: 5e452420d498274a79b91e9a7281f83202066a95

…es, a=testonly Automatic update from web-platform-testsHTML: document.open() and global variables (#10815) For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <timothygu99gmail.com> -- wpt-commits: 70c15a6e508f7460e1584bc8b122ac2cc8f9d6ea wpt-pr: 10815 UltraBlame original commit: bff723cc3832cb0b00fa13a8494ee3aa3bfe74fa

Automatic update from web-platform-testsHTML: document.open() and tasks (#10818) For whatwg/html#3918. -- wpt-commits: 87329a1500b1aea8f9cf28b40afb08491e25a5c7 wpt-pr: 10818 UltraBlame original commit: 06c73a2328c73684f20a24c38a53756f028d66f8

…ation, a=testonly Automatic update from web-platform-testsHTML: Change document.open() test expectation (#12882) For whatwg/html#3918. -- wpt-commits: b70ac6309528aacacfaec186478d0b30b018b8f9 wpt-pr: 12882 UltraBlame original commit: 1f8523944744f115d66ce06088ab103a2c4d6738

…nt, a=testonly Automatic update from web-platform-testsHTML: document.open() and the unload events (#10773) For whatwg/html#3918. -- wpt-commits: 23c21d2e0e6a8035ddfab91e33c54103d859ffca wpt-pr: 10773 UltraBlame original commit: 7a308e5f78c2792c423ec0b5d7e6d6bbafdf230a

…ad event, a=testonly Automatic update from web-platform-testsHTML: document.open() and the beforeunload event (#10778) For whatwg/html#3918. -- wpt-commits: eafe4bdb65ced7352e953ec35c06c3afa3d8125b wpt-pr: 10778 UltraBlame original commit: 5e452420d498274a79b91e9a7281f83202066a95

…es, a=testonly Automatic update from web-platform-testsHTML: document.open() and global variables (#10815) For whatwg/html#3918. Several tests were removed as they no longer apply after the change in HTML. The expectations were reversed and moved to the new no-new-global.window.js file. Co-authored-by: Timothy Gu <timothygu99gmail.com> -- wpt-commits: 70c15a6e508f7460e1584bc8b122ac2cc8f9d6ea wpt-pr: 10815 UltraBlame original commit: bff723cc3832cb0b00fa13a8494ee3aa3bfe74fa

Automatic update from web-platform-testsHTML: document.open() and tasks (#10818) For whatwg/html#3918. -- wpt-commits: 87329a1500b1aea8f9cf28b40afb08491e25a5c7 wpt-pr: 10818 UltraBlame original commit: 06c73a2328c73684f20a24c38a53756f028d66f8

…ation, a=testonly Automatic update from web-platform-testsHTML: Change document.open() test expectation (#12882) For whatwg/html#3918. -- wpt-commits: b70ac6309528aacacfaec186478d0b30b018b8f9 wpt-pr: 12882 UltraBlame original commit: 1f8523944744f115d66ce06088ab103a2c4d6738

TimothyGu requested review from annevk and domenic August 14, 2018 19:08

This was referenced Aug 14, 2018

HTML: document.open() and the unload event web-platform-tests/wpt#10773

Merged

HTML: document.open() and the beforeunload event web-platform-tests/wpt#10778

Merged

HTML: document.open() and global variables web-platform-tests/wpt#10815

Merged

domenic reviewed Aug 14, 2018

View reviewed changes

domenic added removal/deprecation Removing or deprecating a feature topic: multiple globals topic: document.open() labels Aug 14, 2018

annevk approved these changes Aug 15, 2018

View reviewed changes

TimothyGu added 3 commits August 15, 2018 11:12

remove unload recycle parameter

3ab2b71

more cleanups

c7b5ef6

Remove optional param in set the active document

24e11b2

domenic approved these changes Aug 15, 2018

View reviewed changes

TimothyGu mentioned this pull request Aug 16, 2018

Tracking issue for document.open() overhaul #3818

Closed

19 tasks

TimothyGu changed the title ~~Remove document.open() realm creation~~ Remove document.open() realm creation, unloading, and tasks removal Aug 16, 2018

TimothyGu changed the title ~~Remove document.open() realm creation, unloading, and tasks removal~~ document.open() simplifications: realm creation, unloading, tasks removal Aug 16, 2018

domenic merged commit 6f769b8 into whatwg:master Aug 16, 2018

jdm mentioned this pull request Aug 17, 2018

Update document.open implementation to match spec simplification servo/servo#21445

Closed

TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2018

HTML: document.open() and the unload events (#10773)

23c21d2

For whatwg/html#3918.

TimothyGu deleted the document-open-realms branch August 17, 2018 14:06

TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 17, 2018

HTML: document.open() and the beforeunload event (#10778)

eafe4bd

For whatwg/html#3918.

TimothyGu pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 20, 2018

HTML: document.open() and tasks (#10818)

87329a1

For whatwg/html#3918.

zcorpan pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018

HTML: document.open() and the unload events (#10773)

4fd6c72

For whatwg/html#3918.

zcorpan pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018

HTML: document.open() and the beforeunload event (#10778)

d4ddd03

For whatwg/html#3918.

zcorpan pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018

HTML: document.open() and tasks (#10818)

2a6959a

For whatwg/html#3918.

TimothyGu added the normative change label Aug 30, 2018

TimothyGu added a commit to web-platform-tests/wpt that referenced this pull request Sep 6, 2018

HTML: Change document.open() test expectation

e121aa7

For whatwg/html#3918.

TimothyGu mentioned this pull request Sep 6, 2018

HTML: Change document.open() test expectation web-platform-tests/wpt#12882

Merged

TimothyGu added a commit to web-platform-tests/wpt that referenced this pull request Sep 6, 2018

HTML: Change document.open() test expectation (#12882)

b70ac63

For whatwg/html#3918.

miketaylr mentioned this pull request Oct 18, 2018

codesandbox.io - Black Frame instead of animation webcompat/web-bugs#15957

Closed

karlcow mentioned this pull request Nov 20, 2018

www.petflow.com - design is broken webcompat/web-bugs#21558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

document.open() simplifications: realm creation, unloading, tasks removal #3918

document.open() simplifications: realm creation, unloading, tasks removal #3918

Uh oh!

TimothyGu commented Aug 14, 2018 •

edited by pr-preview bot

Loading

Uh oh!

domenic left a comment

Uh oh!

domenic Aug 14, 2018

Uh oh!

domenic commented Aug 14, 2018

Uh oh!

annevk left a comment

Uh oh!

domenic left a comment

Uh oh!

annevk commented Aug 16, 2018

Uh oh!

TimothyGu commented Aug 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

document.open() simplifications: realm creation, unloading, tasks removal #3918

document.open() simplifications: realm creation, unloading, tasks removal #3918

Uh oh!

Conversation

TimothyGu commented Aug 14, 2018 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domenic left a comment

Choose a reason for hiding this comment

Uh oh!

domenic Aug 14, 2018

Choose a reason for hiding this comment

Uh oh!

domenic commented Aug 14, 2018

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

domenic left a comment

Choose a reason for hiding this comment

Uh oh!

annevk commented Aug 16, 2018

Uh oh!

TimothyGu commented Aug 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

TimothyGu commented Aug 14, 2018 •

edited by pr-preview bot

Loading