The "rendered legend" creates a new block formatting context#2718
Merged
The "rendered legend" creates a new block formatting context#2718
Conversation
zcorpan
added
topic: rendering
needs tests
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 1, 2017
zcorpan
removed
the
needs tests
zcorpan
force-pushed
the
zcorpan/legend-bfc
branch
from
660ea1b to
b945845
Compare
Member
Author
|
@yisibl, which name do you prefer in the spec's Acknowledgments? |
|
@zcorpan You can write |
domenic
approved these changes
Jun 6, 2017
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM, will let you merge in case the tests review still has some work to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2519.
Tests: web-platform-tests/wpt#6125