Set "one permitted sandbox navigator" for all sandbox-created popups.#1774
Merged
Set "one permitted sandbox navigator" for all sandbox-created popups.#1774
Conversation
This patch ensures that any browsing context created from a sandboxed document will have its "one permitted sandbox navigator" set. Previously, this property was not set when navigating from a sandboxed document whose "sandbox propagates to auxiliary browsing contexts flag" was not set (e.g. those loaded with 'allow-popups-to-escape-sandbox'), which meant that sandboxed documents could navigate unrelated windows. Closing this hole in the spec aligns with the behavior Firefox plans to ship, and Chrome intends to align with this behavior as well. Addresses #1218.
Member
Author
|
@bzbarsky: I think this is more or less what you suggested. WDYT? |
Contributor
|
Yes, that looks great. |
Member
Author
Member
|
\o/ |
Member
Author
|
Thanks, @domenic! |
stevefaulkner
pushed a commit
to w3c/html
that referenced
this pull request
Nov 3, 2016
W3C-HTML-Bot
pushed a commit
to w3c/html
that referenced
this pull request
Nov 3, 2016
arronei
pushed a commit
to arronei/html
that referenced
this pull request
Apr 17, 2017
This was referenced Mar 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that any browsing context created from a sandboxed
document will have its "one permitted sandbox navigator" set.
Previously, this property was not set when navigating from a sandboxed
document whose "sandbox propagates to auxiliary browsing contexts flag"
was not set (e.g. those loaded with 'allow-popups-to-escape-sandbox'),
which meant that sandboxed documents could navigate unrelated windows.
Closing this hole in the spec aligns with the behavior Firefox plans
to ship, and Chrome intends to align with this behavior as well.
Addresses #1218.