Editorial: make settings object's module map and origin dfns#1721
Merged
Editorial: make settings object's module map and origin dfns#1721
Conversation
|
|
||
| <dt>A <span>module map</span></dt> | ||
| <dt>A <dfn data-x="concept-settings-object-module-map" data-export="" data-dfn-for="environment | ||
| settings object">module map</dfn></dt> |
Member
There was a problem hiding this comment.
Maybe also do referrer policy while you're here, since we forgot to do so in the last patch?
Member
Author
There was a problem hiding this comment.
Doesn't 32c7978 do that? (Note that this PR is behind.)
Member
There was a problem hiding this comment.
Ah yes it does, I just read it wrong. 👍
Member
|
Looks great with the above two suggestions. |
Member
|
Yay this is really nice. If we ever go make Document's origin refer to https://dom.spec.whatwg.org/#concept-document-origin we'll have even more fun... |
Member
Author
|
Yeah, while doing this one I noticed that's going to be some work, but I should probably do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #1718 to let folks be more specific when talking about module maps and origins.