Skip to content

Editorial: make settings object's referrer policy a dfn#1718

Merged
domenic merged 1 commit intomasterfrom
settings-object-referrer-policy
Aug 29, 2016
Merged

Editorial: make settings object's referrer policy a dfn#1718
domenic merged 1 commit intomasterfrom
settings-object-referrer-policy

Conversation

@annevk
Copy link
Copy Markdown
Member

@annevk annevk commented Aug 26, 2016

This allows Fetch and Referrer Policy to reference it directly. In
addition, move the definition of referrer policy itself per changes in
Fetch and Referrer Policy.

@domenic
Copy link
Copy Markdown
Member

domenic commented Aug 26, 2016

This appears to be out of date. The definition for referrer policy moved, but also you seem to have deleted the definition of a request's referrer policy, which we should keep...

@domenic
Copy link
Copy Markdown
Member

domenic commented Aug 27, 2016

Re-reviewing this with an eye toward what it is actually trying to accomplish, I think it is probably a good idea, once rebased and disentangled from the other change. I wonder if we should do the same thing for module map and origin.

@annevk
Copy link
Copy Markdown
Member Author

annevk commented Aug 27, 2016

I can change those too if you want. Somewhere Monday.

@domenic
Copy link
Copy Markdown
Member

domenic commented Aug 27, 2016

Sure, if you're up for it, although I think there will be a lot of references to them (especially to origin) that need updating. Either together or in a separate patch is good.

This allows Fetch and Referrer Policy to reference it directly. In
addition, move the definition of referrer policy itself per changes in
Fetch and Referrer Policy.
@annevk annevk force-pushed the settings-object-referrer-policy branch from f2ee3ac to 58197f4 Compare August 29, 2016 07:42
@annevk
Copy link
Copy Markdown
Member Author

annevk commented Aug 29, 2016

This should be good now. I don't think I ever removed request's referrer policy btw, I just moved something similar to what a PR you created did since that had not landed at the time (and I included "The" and "concept" around it).

@domenic domenic merged commit 32c7978 into master Aug 29, 2016
@domenic domenic deleted the settings-object-referrer-policy branch August 29, 2016 18:36
domenic pushed a commit that referenced this pull request Aug 29, 2016
A follow up to #1718 to let folks be more specific when talking about
module maps and origins.
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
A follow up to whatwg#1718 to let folks be more specific when talking about
module maps and origins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants