Make forms work in shadow trees#1135
Conversation
|
I suspect the submit event needs to be scoped. That's not done yet. Not sure about other form-specific events... Seems submit is not mentioned by https://w3c.github.io/webcomponents/spec/shadow/#scoped-flag but that's probably a bug. @hayatoito, @smaug----, thoughts? |
|
It probably should indeed. Otherwise the light DOM may get odd submit events which aren't coming from any form. Same with reset. Not sure about other events like input/change, since one could implement a new form-widget-like element using shadow DOM and such element might be used outside any form, just like and such. |
|
This also fixes #833. Note that |
|
I was thinking that but it isn't much different to some script in shadow dom doing location.href = "somenewpage". |
|
LGTM. |
|
FYI, @rniwa. |
|
I annotated the "invalid" event as needing to be scoped, though maybe that's in the same realm as "input" and "change"... |
|
This also fixes #283 it seems. Yay. |
|
Once we have figured out scoped vs unscoped this can probably land with some slight changes. Making it clear we should wait a little bit for now. |
|
I removed the changes that make this resolve #833. I also removed the scoped event annotations now they are scoped by default. |
|
Yeah, LGTM. |
No description provided.