Upstream IDL changes from Trusted Types #10199

lukewarlow · 2024-03-13T17:32:11Z

At least two implementers are interested (and none opposed):
- Chromium
- Gecko
Tests are written and can be reviewed and commented upon at:
- https://wpt.live/trusted-types/
Implementation bugs are filed:
- Chromium: Shipped
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1508286
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=266630
- Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): Not sure it's relevant to Deno?
- Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
MDN issue is filed: Not applicable? Trusted Types as an API is already documented with examples of sinks.
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/workers.html ( diff )

lukewarlow · 2024-03-13T17:35:44Z

Sections to upstream:

https://w3c.github.io/trusted-types/dist/spec/#extensions-to-the-windoworworkerglobalscope-interface - Not upstreaming as I don't think it's the norm to.
https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-document-interface
https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-domparser-interface
https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-element-shadowroot-interfaces
https://w3c.github.io/trusted-types/dist/spec/#html-workers
[-] https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-sinks - Only HTMLIframeElement srcdoc upstreamed
https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-scripts - Still WIP so not upstreaming yet
https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-timer-functions - Still WIP so not upstreaming yet
https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-event-handler-content-attributes - Still WIP so not upstreaming yet
https://w3c.github.io/trusted-types/dist/spec/#html-validate-the-string-in-context - Will be upstreamed as a separate PR

annevk

Inside an IDL block we use <span> to reference code constructs, not <code>. Looks mostly good otherwise.

source

annevk

@dontcallmedom do you foresee this causing any issues for the various IDL tools?

source

dontcallmedom · 2024-03-15T13:48:22Z

@dontcallmedom do you foresee this causing any issues for the various IDL tools?

none that I can see

annevk

I'll leave it to @domenic and @zcorpan whether they're okay with doing this incrementally.

source

zcorpan · 2024-03-18T21:30:46Z

I think incremental upstreaming is OK.

Are the open threads above resolved?

lukewarlow · 2024-03-18T21:34:58Z

Are the open threads above resolved?

Yeah apologies forgot to close them.

lukewarlow · 2024-03-18T22:54:16Z

is there a preference for what the commit message should say? And is there anything else that I need to do?

zcorpan · 2024-03-19T10:59:02Z

Upstream IDL changes from Trusted Types

Part of https://github.com/w3c/trusted-types/issues/476

and maybe repost #10199 (comment) there, since it's the tracking issue for upstreaming.

Part of w3c/trusted-types#476

lukewarlow · 2024-03-19T11:36:35Z

Have changed the commit message and reposted that comment

See whatwg/html#10199

lukewarlow force-pushed the trusted-types branch from 309d8b4 to 496dd6c Compare March 13, 2024 17:37

lukewarlow mentioned this pull request Mar 13, 2024

[Meta] Upstream changes w3c/trusted-types#476

Open

annevk reviewed Mar 14, 2024

View reviewed changes

source Outdated Show resolved Hide resolved

source Outdated Show resolved Hide resolved

lukewarlow force-pushed the trusted-types branch from 496dd6c to 59df532 Compare March 14, 2024 12:34

lukewarlow marked this pull request as ready for review March 14, 2024 12:38

lukewarlow requested a review from annevk March 14, 2024 12:39

annevk reviewed Mar 15, 2024

View reviewed changes

source Show resolved Hide resolved

source Outdated Show resolved Hide resolved

annevk approved these changes Mar 15, 2024

View reviewed changes

source Outdated Show resolved Hide resolved

annevk mentioned this pull request Mar 18, 2024

Add getHTML() and the serializable concept #10139

Merged

5 tasks

zcorpan approved these changes Mar 18, 2024

View reviewed changes

Upstream IDL changes from Trusted Types

8a2505f

Part of w3c/trusted-types#476

lukewarlow force-pushed the trusted-types branch from ae150e6 to 8a2505f Compare March 19, 2024 11:35

zcorpan merged commit cf95931 into whatwg:main Mar 19, 2024

lukewarlow added a commit to lukewarlow/trusted-types that referenced this pull request Mar 19, 2024

Remove IDL changes upstreamed to HTML

c1c4e41

See whatwg/html#10199

lukewarlow mentioned this pull request Mar 19, 2024

Remove IDL changes upstreamed to HTML w3c/trusted-types#485

Merged

lukewarlow added a commit to lukewarlow/trusted-types that referenced this pull request Mar 19, 2024

Remove IDL changes upstreamed to HTML

5dbcd73

See whatwg/html#10199

lukewarlow added a commit to w3c/trusted-types that referenced this pull request Mar 25, 2024

Remove IDL changes upstreamed to HTML (#485)

b38b323

See whatwg/html#10199

zcorpan mentioned this pull request May 28, 2024

Switch trusted types sinks to use union type #10286

Merged

5 tasks

TimvdLippe mentioned this pull request Apr 1, 2025

Implement Trusted Types servo/servo#36258

Closed

Upstream IDL changes from Trusted Types #10199

Upstream IDL changes from Trusted Types #10199

Uh oh!

Conversation

lukewarlow commented Mar 13, 2024 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukewarlow commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dontcallmedom commented Mar 15, 2024

Uh oh!

annevk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zcorpan commented Mar 18, 2024

Uh oh!

lukewarlow commented Mar 18, 2024

Uh oh!

lukewarlow commented Mar 18, 2024

Uh oh!

zcorpan commented Mar 19, 2024

Uh oh!

lukewarlow commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

lukewarlow commented Mar 13, 2024 •

edited by pr-preview bot

Loading

lukewarlow commented Mar 13, 2024 •

edited

Loading