Merged
Conversation
hsivonen
approved these changes
Oct 21, 2020
Member
hsivonen
left a comment
hsivonen
left a comment
There was a problem hiding this comment.
I take it that the new hook will be in a different PR.
Member
|
Since #238 has "encode or fail" passing an encoder instance (rather than an encoder "class", so to speak) to "run", it's probably best to update that algorithm in this PR to take an instance and to change the hooks that call it to use "run a new instance of |
Member
Author
|
Let's make those changes there if we keep that as initially proposed. I rather like putting the errors directly in the queue though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andreubotella would appreciate your thoughts on this as well. I wanted to split this section into two given that I need two new algorithms for the URL standard (get an encoder and encode or fail) that both are somewhat wonky and probably need a bit of explanation and it seems bad to explain that together with all the UTF-8-centric primitives everyone ought to be using.
Preview | Diff