Specify [LegacyWindowAlias=HTMLDocument] on Document#551
Specify [LegacyWindowAlias=HTMLDocument] on Document#551TimothyGu wants to merge 1 commit intowhatwg:masterfrom
Conversation
|
LGTM |
|
I think it'd still be a good idea to add this here as it's a non-normative change that makes things easier to understand while reading the spec. (And also easier for any implementations like Servo or jsdom that implement it exactly.) We could separately add a warning about #221 and #278, but I'd like to see this merged if possible. |
|
When I talked it through with @foolip it sounds like the solution will be that we have |
|
Only Safari has SVGDocument (as an alias of XMLDocument) so we don't need that. |
|
Unfortunately, it looks like whatwg/html#4792 might throw a spanner into this. |
|
Closing as it seems even more unlikely we'll end up using this at this point. |
6 participants
In https://html.spec.whatwg.org/multipage/window-object.html#the-window-object there is:
I'd like to get rid of that using the still relatively new [
LegacyWindowAlias] extended attribute. However, Web IDL forbids that extended attribute from being used on partial interface definitions, and thus I had to open the PR here rather than as HTML. As much as I hate putting more HTML-specific things in DOM, I think this is minor enough to be okay.As soon as this gets merged I'll open a PR to HTML removing that paragraph.
/cc @tobie
Preview | Diff