Require CMake 3.10 or newer#98
Merged
Ybalrid merged 2 commits intowgois:masterfrom Oct 14, 2025
gruenich:master
Merged
Conversation
CMake 4.0 refuses to work with minimum require of CMake 3.4 or below. Everything below 3.10 is deprecated.
Contributor
Author
|
Once this is merged, would be nice to get a release to make packaging easier. (#97) |
Contributor
Author
|
@Ybalrid Do you mind merging this? |
13 tasks
Contributor
|
It looks like this line must also be removed from the diff --git a/CMakeLists.txt b/CMakeLists.txt
index 98c67d3..006b36b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -218,7 +218,6 @@ endif()
if(UNIX)
if (NOT APPLE)
- add_dependencies(OIS X11)
target_link_libraries(OIS X11)
endif()
|
Contributor
Author
|
@Sirius902 I added a second commit with you as the author. Please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Increase minimum required version of CMake to 3.10.
Affected backeds (DirectInput, X11... Fill in if applicable)
does not apply