Repository navigation
Commit 51c03bc
committed
TlsSession: address PR dotnet#130366 review feedback
Code fixes (all in TlsSession.cs):
- Remove debug 'CAPTURE-DEBUG' InvalidOperationException that was leaking
a debug marker to consumers; silently skip ClientHello capture when the
parse succeeds but the frame length doesn't fit (already benign).
- Fix ArrayPool leak in HandshakeSocketCore / ReadSocketCore: replace
Array.Resize on the pool-rented _socketInBuf with a proper Rent/Copy/
Return via new GrowSocketInBuf() helper. Prevents leaking the original
pooled buffer and prevents returning a non-pooled resized array back
to the pool on Dispose.
- Fix SetClientCertificateContext race with concurrent sessions: instead
of disposing/nulling the shared TlsContext.CredentialsHandle, acquire a
session-local credentials handle (mirroring the pattern in SetContext).
ActiveCredentialsRef() already routes subsequent PAL calls through the
session-local handle. Acquire eagerly so failures surface here.
Squash-regression restores:
- System.Net.Security.csproj: restore $(NetCoreAppCurrent)-openbsd TFM
that was dropped from TargetFrameworks.
- System.Net.Security.csproj: fix stale ReadWriteAdapter.cs path — the
file lives at $(CommonPath)System/ (not System/Net/).
- LocalAppContextSwitches.cs: restore IsOpenBsd flag used by
NegotiateAuthenticationPal.ManagedSpnego on OpenBSD.
- docs/project/list-of-diagnostics.md: restore SYSLIB0065 row and update
the SYSLIB5007 row to .NET 11 with the wording proposed by @vcsjones.1 parent ada2c85 commit 51c03bc
4 files changed
Lines changed: 45 additions & 14 deletions
File tree
- docs/project
- src/libraries/System.Net.Security/src
- System/Net/Security
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
122 | 123 | | |
123 | 124 | | |
124 | 125 | | |
| |||
319 | 320 | | |
320 | 321 | | |
321 | 322 | | |
322 | | - | |
| 323 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
131 | | - | |
| 130 | + | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
575 | 575 | | |
576 | 576 | | |
577 | 577 | | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
582 | 587 | | |
583 | 588 | | |
584 | 589 | | |
| |||
785 | 790 | | |
786 | 791 | | |
787 | 792 | | |
788 | | - | |
789 | | - | |
790 | | - | |
791 | | - | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
792 | 796 | | |
793 | 797 | | |
794 | 798 | | |
| |||
1800 | 1804 | | |
1801 | 1805 | | |
1802 | 1806 | | |
| 1807 | + | |
| 1808 | + | |
| 1809 | + | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
| 1817 | + | |
| 1818 | + | |
| 1819 | + | |
| 1820 | + | |
| 1821 | + | |
| 1822 | + | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
1803 | 1829 | | |
1804 | 1830 | | |
1805 | 1831 | | |
| |||
1890 | 1916 | | |
1891 | 1917 | | |
1892 | 1918 | | |
1893 | | - | |
| 1919 | + | |
1894 | 1920 | | |
1895 | 1921 | | |
1896 | 1922 | | |
| |||
1990 | 2016 | | |
1991 | 2017 | | |
1992 | 2018 | | |
1993 | | - | |
| 2019 | + | |
1994 | 2020 | | |
1995 | 2021 | | |
1996 | 2022 | | |
| |||
0 commit comments