Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Added attribution option to transaction parameters#187

Merged
tmm merged 3 commits intowevm:mainfrom
ggomaeng:attribution-flag
Mar 27, 2024
Merged

Added attribution option to transaction parameters#187
tmm merged 3 commits intowevm:mainfrom
ggomaeng:attribution-flag

Conversation

@ggomaeng
Copy link
Copy Markdown
Contributor

Follow up of #172 and #177


Calling allowance calls within Desktop Metamask fails, which would be fixed by MetaMask/metamask-extension#23527.

However, that wouldn't solve the problem of sending ETH to a contract address using eth_sendTransaction.

Sending ETH to a contract address always reverts when attribution option is true or undefined.

@dalechyn suggested we should have attribution flag false by default, and let users include them if needed.


Below is an example Warpcast Simulation parameters when sending ETH to a contract address using c.res or c.send.

transaction": {
    "method": "eth_sendTransaction",
    "params": {
        "to": "0xeac856237a85b70338a32b55bf44b13ef1a7811d",
        "data": "0xfc000023c0",
        "value": "5000000000000000",
        "chainId": "8453",
        "from": "0x130946d8dF113e45f44e13575012D0cFF1E53e37"
    }
},

Related discord Conversation: https://discord.com/channels/1156791276818157609/1221669227182821406

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 4:19am
frog-frame ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 4:19am

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2024

@ggomaeng is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@dalechyn dalechyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Vladyslav Dalechyn <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants