This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Added attribution option to transaction parameters#187
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ggomaeng is attempting to deploy a commit to the wevm Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Mar 25, 2024
dalechyn
reviewed
Mar 25, 2024
Co-authored-by: Vladyslav Dalechyn <[email protected]>
tmm
reviewed
Mar 25, 2024
Co-authored-by: awkweb <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #172 and #177
Calling allowance calls within Desktop Metamaskfails, which would be fixed by MetaMask/metamask-extension#23527.However, that wouldn't solve the problem of sending ETH to a
contract addressusingeth_sendTransaction.Sending ETH to a contract address always reverts when
attributionoption istrueorundefined.@dalechyn suggested we should have
attributionflag false by default, and let users include them if needed.Below is an example Warpcast Simulation parameters when sending ETH to a contract address using
c.resorc.send.Related discord Conversation: https://discord.com/channels/1156791276818157609/1221669227182821406