Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Added attribution parameter to transactions#172

Closed
ggomaeng wants to merge 3 commits intowevm:mainfrom
ggomaeng:main
Closed

Added attribution parameter to transactions#172
ggomaeng wants to merge 3 commits intowevm:mainfrom
ggomaeng:main

Conversation

@ggomaeng
Copy link
Copy Markdown
Contributor

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:29am
frog-frame ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:29am

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 21, 2024

@ggomaeng is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

@ggomaeng ggomaeng changed the title Add attribution parameter to transactions Added attribution parameter to transactions Mar 21, 2024
@dalechyn
Copy link
Copy Markdown
Collaborator

I believe it's also worth noting in https://frog.fm/concepts/transactions and set attribution: false everywhere with a note that when MetaMask/metamask-extension#23527 is merged, this will be no longer needed.

@ggomaeng
Copy link
Copy Markdown
Contributor Author

ggomaeng commented Mar 22, 2024

I believe it's also worth noting in https://frog.fm/concepts/transactions and set attribution: false everywhere with a note that when MetaMask/metamask-extension#23527 is merged, this will be no longer needed.

That's true. If that's the case, I think it would be better to not merge this PR.

Instead, it would be better to just provide an example of adding additional specs via middleware like @tmm mentioned here

I'll update the PR soon.

@ggomaeng
Copy link
Copy Markdown
Contributor Author

I believe it's also worth noting in https://frog.fm/concepts/transactions and set attribution: false everywhere with a note that when MetaMask/metamask-extension#23527 is merged, this will be no longer needed.

@dalechyn continuing this thread in #177

@ggomaeng
Copy link
Copy Markdown
Contributor Author

#177 is closed. Continuing in #187

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants