Rename remaining references of "selected" to "highlighted"#95
Merged
westonruter merged 13 commits intomasterfrom May 6, 2020
Merged
Rename remaining references of "selected" to "highlighted"#95westonruter merged 13 commits intomasterfrom
westonruter merged 13 commits intomasterfrom
Conversation
Contributor
|
I added f67b59d because this was the second time we had forgot to update our transient rendering 😅 |
allejo
approved these changes
May 6, 2020
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR amends #92 to further fix #84.
Also:
backgroundinstead ofbg.get_option()function from core by renaming toget_plugin_option(). Also prevent non-existent option from causing PHP error.syntax_highlighting_code_selected_line_bgfilter tosyntax_highlighted_line_background_color.shcb-selected-linesclass name.