Rename attributes#92
Merged
westonruter merged 3 commits intomasterfrom May 6, 2020
Merged
Conversation
Owner
Author
This is what I was trying without luck: diff --git a/src/index.js b/src/index.js
index 304a5c7..2338a09 100644
--- a/src/index.js
+++ b/src/index.js
@@ -270,6 +270,30 @@ const extendCodeBlockWithSyntaxHighlighting = (settings) => {
</pre>
);
},
+
+ deprecated: [
+ ...(settings.deprecated || []),
+ {
+ attributes: {
+ ...settings.attributes,
+ language: {
+ type: 'string',
+ },
+ showLines: {
+ type: 'boolean',
+ },
+ },
+ migrate(attributes, innerBlocks) {
+ return [
+ {
+ language: attributes.language,
+ showLineNumbers: attributes.showLines,
+ },
+ innerBlocks,
+ ];
+ },
+ },
+ ],
};
}; |
Contributor
|
How does 8561992 work for you? |
allejo
reviewed
May 6, 2020
Owner
Author
Wow. You did it! I missed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
This PR renames attributes as follows:
selectedLineshighlightedLinesshowLinesshowLineNumbersWhen rendering the block on the frontend, the old attributes will still work.
However, when opening the post editor the old deprecated attributes will need to be re-populated. I didn't implement migration of these old attributes because (1) only
showLinesis in a current release, (2) there are only 400 active installs of this plugin currently, and (3) I wasn't sure how best to do it on the JS side of things.