Define attribute schema in PHP with registered block type#83
Merged
westonruter merged 2 commits intomasterfrom Apr 26, 2020
Merged
Define attribute schema in PHP with registered block type#83westonruter merged 2 commits intomasterfrom
westonruter merged 2 commits intomasterfrom
Conversation
allejo
approved these changes
Apr 26, 2020
Contributor
allejo
left a comment
There was a problem hiding this comment.
I love this! Didn't realize you could define settings centrally in PHP. Should your example code this be added to the README?
Owner
Author
|
Yes, I was thinking we should create a wiki page here in GitHub with those extensibility examples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines the block attributes centrally in PHP. This allows for plugins to easily change the default values for a block's attributes. For example, if a site wants all blocks to have wrapped lines and have PHP selected by default, they can do so with this code:
The great thing about this is that the defaults will be reflected in the editor and for every instance of the generic Code block already created when rendered on the frontend.
This PR also removes obsolete deprecated block definition which is now only relevant in mkaz/code-syntax-block.