Skip to content

Fix compatibility with Gutenberg 17.1 after it removed preserveWhiteSpace serialisation differences#791

Merged
westonruter merged 3 commits intodevelopfrom
fix/pre-br
Jan 20, 2024
Merged

Fix compatibility with Gutenberg 17.1 after it removed preserveWhiteSpace serialisation differences#791
westonruter merged 3 commits intodevelopfrom
fix/pre-br

Conversation

@westonruter
Copy link
Copy Markdown
Owner

@westonruter westonruter commented Dec 2, 2023

Fixes #790.

In Gutenberg 17.1, I paste the following into a new Code block:

<!DOCTYPE html>
<html>
    <head>
        <title>PHP Test</title>
    </head>
    <body>
        <?php echo '<p>Hello World</p>'; ?>
    </body>
</html>

When I look at the post_content, it shows the block markup as follows:

<!-- wp:code {"language":"xml"} -->
<pre class="wp-block-code"><code>&lt;!DOCTYPE html><br>&lt;html><br>    &lt;head><br>        &lt;title>PHP Test&lt;/title><br>    &lt;/head><br>    &lt;body><br>        &lt;?php echo '&lt;p>Hello World&lt;/p>'; ?><br>    &lt;/body><br>&lt;/html></code></pre>
<!-- /wp:code -->

This gets rendered as:

image

When this is what is expected:

image

This PR fixes the problem by ensuring BR tags are replaced with newlines before applying syntax highlighting.

@westonruter
Copy link
Copy Markdown
Owner Author

westonruter commented Dec 2, 2023

ZIP build: syntax-highlighting-code-block.zip (1.5.0-alpha-20231202T000854Z-3dc095a)

This was referenced Dec 2, 2023
Closed
Merged
@westonruter westonruter merged commit dc0111c into develop Jan 20, 2024
@westonruter westonruter deleted the fix/pre-br branch January 20, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

br tags being added instead of line breaks

1 participant

@westonruter