Skip to content

Fix loading script dependencies list #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 3 commits into from
Apr 22, 2020
Merged

Fix loading script dependencies list #74

westonruter merged 3 commits into from
Apr 22, 2020

Conversation

@westonruter
Copy link
Owner

@westonruter westonruter commented Apr 22, 2020 •
edited
Loading

With the update to the WordPress packages (e.g. #71, #89), the list of dependencies for a given script is now defined in index.asset.php rather than index.deps.json. This makes that required change.

@westonruter westonruter requested a review from allejo April 22, 2020 04:18
allejo
allejo approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@westonruter westonruter merged commit ce2a397 into master Apr 22, 2020
@westonruter westonruter deleted the fix/asset-dependencies branch April 22, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@allejo allejo allejo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@westonruter @allejo