Skip to content

Move functions to inc/ #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonruter merged 6 commits into from
Apr 21, 2023
Merged

Move functions to inc/ #721

westonruter merged 6 commits into from
Apr 21, 2023

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 21, 2023 •
edited
Loading

@westonruter New structure & readable main file :)

  • Moved functions from plugin main file to inc/functions.php
  • New boot function
  • PHPStan result cache 🚀
  • Two new constants for PHP magic constants

source

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 21, 2023

All green 🍏

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 21, 2023

Oh nooooooooooooooooooooooo!
Resolving a TODO ends up adding a new TODO 🙃

@westonruter
Copy link
Owner

westonruter commented Apr 21, 2023

Thanks. I was going to move into a directory as part of a larger refactor, but probably better to make this change now.

@westonruter westonruter merged commit 0ecf49d into westonruter:develop Apr 21, 2023
@szepeviktor szepeviktor deleted the inc branch April 21, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @westonruter