Register editor script/style with block instead of using enqueue_block_editor_assets
#690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689
Previously the plugin was enqueuing the editor script and style manually at the
enqueue_block_editor_assetsaction. This broke as of Gutenberg 14.8 in which aneditor-canvasiframe was introduced to encapsulate the edited blocks. The issue is fixed by registering the script and style via theeditor_script_handlesandeditor_style_handlesprops ofWP_Block_Type, respectively, which allows WordPress to know specifically which assets need to be enqueued in theeditor-canvas.