Register styles at wp_default_styles not wp_enqueue_scripts #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
allejo
approved these changes
Feb 17, 2020
Contributor
|
I take it that |
Owner
Author
|
I suppose that's one reason as well. The main reason is pure registration works best in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered when testing ampproject/amp-wp#4299, which adds block styles to AMP pages in Reader mode, that this plugin's stylesheet was not added. The reason for this is the plugin was using
wp_enqueue_scriptsto register the stylesheet, but this is not currently invoked in AMP's Reader mode (onlyenqueue_block_assets).Most plugins would be using
enqueue_block_assetsto both register and enqueue stylesheets so they wouldn't be impacted by here. But in this plugin we defer printing the stylesheet until the block is printed.Before:
After: