Html error fix (div changed to span) #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
allejo
approved these changes
Feb 11, 2021
Contributor
allejo
left a comment
allejo
left a comment
There was a problem hiding this comment.
LGTM 👍
Just for future documentation, I'm using the Twenty Twenty theme and it's the .wp-block-code class that plays a role in this (see #80 (comment)).
Without this extra DOM element of a display: block, a code block will render like this:
However, with the extra DOM element that is a display: block, it will look correctly like so:
Result: any DOM element with a display: block will fix the overflow issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes html error (
divinsidepretag). As discussedstyletag inside body stays.Fixes #280.