Fix font-size handling and line wrapping in latest Gutenberg#230
Merged
westonruter merged 5 commits intodevelopfrom Dec 3, 2020
Merged
Fix font-size handling and line wrapping in latest Gutenberg#230westonruter merged 5 commits intodevelopfrom
westonruter merged 5 commits intodevelopfrom
Conversation
allejo
approved these changes
Dec 3, 2020
Comment on lines
+282
to
+283
| // Copy the styles to ensure that the code-block-overlay is updated when the font size is changed in Gutenberg 9.5+. | ||
| textAreaProps.style = blockProps.style; |
Contributor
There was a problem hiding this comment.
This is what I was missing!! I was exploring to see how Gutenberg had changed but didn't think to copy over the styles. I love it 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228
Fixes #229
RichTextcomponent is used instead ofPlainText. Line wrapping (or no-wrapping) is also now applies as expected. This was missed in a previous PR.👎 Before, upon changing the font size to small or large:
👍 After: