Fix problems with splitCodeIntoArray
#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
approved these changes
Oct 16, 2020
Owner
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Given this post_content:
<!-- wp:code {"language":"java","showLineNumbers":true} -->
<pre class="wp-block-code"><code>public QuoteEntity(
)</code></pre>
<!-- /wp:code -->
<!-- wp:code {"language":"java","showLineNumbers":true} -->
<pre class="wp-block-code"><code></code></pre>
<!-- /wp:code -->Before
There is an error in the markup:
<!-- UnexpectedValueException(0): The given HTML could not be parsed correctly. -->And there is a warning in the error log:
PHP Warning: DOMDocument::loadHTML(): Empty string supplied as input in /app/public/content/plugins/syntax-highlighting-code-block/vendor/scrivo/highlight.php/HighlightUtilities/functions.php on line 179
After
No warning appears in the log and instead of the HTML comment, we instead get:
<pre class="wp-block-code"><div><code class="hljs language-java shcb-code-table shcb-line-numbers"></code></div></pre>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump highlight.php to v9.18.1.3, which has two fixes with how
splitCodeIntoArrayworks.Fixes #189
Fixes #193