Add missing escape() of Code block content in save function#119
Merged
westonruter merged 2 commits intodevelopfrom Jun 27, 2020
Merged
Add missing escape() of Code block content in save function#119westonruter merged 2 commits intodevelopfrom
westonruter merged 2 commits intodevelopfrom
Conversation
Closed
ghost
approved these changes
Jun 24, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I checked once again. According to the DiffChecker, the code has not been changed by the plugin and everything looks correct: https://www.diffchecker.com/BYP957zg
Thank you very much,
Best regards.
allejo
approved these changes
Jun 25, 2020
Contributor
allejo
left a comment
allejo
left a comment
There was a problem hiding this comment.
Oof, those revert commit messages lol
LGTM 👍 things appear to be working fine for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously #118. Fixes #110.
As noted in #118 (comment), omitting the
savefunction to reuse the one from core is not reliable. While waiting to determine why specifically that is, I'll just copy the logic from core/Gutenberg.Build for testing: syntax-highlighting-code-block.zip