Skip to content

Confirm identifiers for attributes #84

@westonruter

Description

@westonruter

We currently have these block attributes:

  • language
  • selectedLines
  • showLines
  • wrapLines

Before we release 1.2 and blocks out in the wild start using these, we should make sure we're happy with them. I realize that showLines is actually live already, but selectedLines and wrapLines are not. I'm thinking the names don't entirely reflect what the properties do. The

Old New Note
selectedLines highlightedLines Because the UI uses “Highlighted Lines”.
showLines showLineNumbers Lines are always shown. It's the numbers that are in view here. This also corresponds with the UI which has “Show Line Numbers”.

I think we can support the showLines as a legacy property name which we automatically copy to showLineNumbers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions