Integrate with frontend login forms #19
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @westonruter, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the bfcache integration by extending its functionality to frontend login forms, which are commonly used by plugins like WooCommerce and BuddyPress. It refactors the JavaScript detection logic into a dedicated module, ensuring that the system can accurately determine if JavaScript is enabled for all login scenarios. Additionally, it includes minor performance optimizations and documentation updates related to bfcache invalidation strategies.
Highlights
- Frontend Login Form Integration: Extended the bfcache opt-in mechanism to support frontend login forms (e.g., those used by WooCommerce or BuddyPress). This ensures that the JavaScript-enabled detection and subsequent bfcache behavior apply consistently across all login entry points.
- Dedicated JavaScript Detection: Introduced a new JavaScript module (
js/detect-scripting-enabled-at-login.js) specifically responsible for setting a cookie to indicate that JavaScript is enabled when a login form is submitted. This logic was previously part ofjs/bfcache-opt-in.jsbut has been refactored for clarity and broader applicability. - Script Enqueueing for Frontend Forms: Implemented a method to enqueue the necessary JavaScript modules for frontend login forms by 'hackily' leveraging the
login_form_defaultsfilter, as direct actions are not available for these forms. - Performance Optimization: Added a filter to set
fetchpriority='low'for all bfcache-related script modules, aiming to improve page load performance by deprioritizing these scripts. - Documentation and To-Dos: Updated the
README.mdto clarify limitations of theClear-Site-Dataheader (e.g., non-secure contexts) and addedtodocomments inincludes/bfcache-invalidation.phpregarding conditionalClear-Site-Datasending and potential performance issues.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The code changes introduce the ability for login forms submitted from the frontend to opt-in to bfcache. The changes include a new script module to detect whether scripting is enabled at login, and a modification to the existing bfcache opt-in script module. The changes also include a filter to enqueue scripts for frontend login forms.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This ensures that login forms submitted from the frontend can also opt-in to bfcache. This is is key for sites using WooCommerce and BuddyPress.
Note that the sparkle button does not appear with the Remember Me checkbox for the frontend login forms in order to not interfere with the site's styling.