Sketch of safe-call-into-r#10
Closed
westonpace wants to merge 9 commits intoexperiment/serial-generatorfrom
Closed
Sketch of safe-call-into-r#10westonpace wants to merge 9 commits intoexperiment/serial-generatorfrom
westonpace wants to merge 9 commits intoexperiment/serial-generatorfrom
Conversation
…ror occurs, we make sure to finish up any ongoing tasks before we return the error. This prevents tasks from outliving the generator
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
c4d7f07 to
2978c1b
Compare
4fd18dc to
e3f588f
Compare
e3f588f to
c4464dd
Compare
westonpace
pushed a commit
that referenced
this pull request
Jul 14, 2022
…ation (apache#13579) When locally building the `conda-cpp-valgrind` docker image I've realised we are prompting for confirmation: ``` #10 12.35 Confirm changes: [Y/n] #10 88.01 ``` We should use the -y flag when using mamba install: ``` -y, --yes Do not ask for confirmation. ``` With this change we are no longer seeing the `Confirm changes` message from mamba. Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may have been a little optimistic. This approach should be able to work. However, we may have to expose C++'s async API to make it happen. The problem with using a sync call is...
When using an async call...
Also, I'm not using later::run_now because we have event loops in C++ already (SerialExecutor). But, you could definitely use later event loops if you wanted.