Fix page up/down scroll to preserve cursor position#90
Merged
Conversation
Page up/down was using pageSize instead of visibleRows (pageSize-1), moving one row too far per page. Additionally, ensureCursorVisible() was snapping the cursor to the viewport edge after paging, losing the user's relative position. Now both cursor and scrollOffset move together by visibleRows, and the same fix is applied to thread view paging. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Cover the thread view paging code path in keys.go with table-driven tests for page down and page up, including empty and small thread edge cases. Addresses review finding about missing thread view test coverage. Co-Authored-By: Claude Opus 4.6 <[email protected]>
wesm
added a commit
to robelkin/msgvault
that referenced
this pull request
Feb 7, 2026
## Summary - **Off-by-one fix**: Page up/down now moves by `visibleRows()` (pageSize-1) instead of `pageSize`, accounting for the info line that occupies one row - **Position preservation**: Cursor and scrollOffset move together during paging, so the cursor stays at the same relative position in the viewport instead of snapping to the edge - **Thread view**: Same fixes applied to thread view page up/down in `keys.go` ## Changes - `navigation.go`: Added `visibleRows()` helper, fixed `navigateList` page up/down to move cursor+scrollOffset together and return early (skipping `ensureCursorVisible`), simplified `ensureCursorVisible`/`ensureThreadCursorVisible` - `keys.go`: Fixed thread view page up/down with same pattern - `nav_test.go`: Added table-driven tests for page down, page up, and `visibleRows()` edge cases ## Test plan - [x] `go test ./internal/tui/ -v` — all pass - [x] `make lint` — clean - [x] `make test` — all pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibleRows()(pageSize-1) instead ofpageSize, accounting for the info line that occupies one rowkeys.goChanges
navigation.go: AddedvisibleRows()helper, fixednavigateListpage up/down to move cursor+scrollOffset together and return early (skippingensureCursorVisible), simplifiedensureCursorVisible/ensureThreadCursorVisiblekeys.go: Fixed thread view page up/down with same patternnav_test.go: Added table-driven tests for page down, page up, andvisibleRows()edge casesTest plan
go test ./internal/tui/ -v— all passmake lint— cleanmake test— all pass🤖 Generated with Claude Code