Command Injection Risk in OAuth Browser Launch (CRITICAL)#68
Merged
Conversation
Contributor
hughdbrown
commented
Feb 5, 2026
hughdbrown
commented
- Location: internal/oauth/oauth.go:325-339
- Issue: openBrowser() passes URL to exec.Command(). While not using shell, an attacker controlling OAuth redirect could potentially craft malicious URLs.
- Fix: Validate URL format/scheme before passing to exec.Command().
- Location: internal/oauth/oauth.go:325-339 - Issue: openBrowser() passes URL to exec.Command(). While not using shell, an attacker controlling OAuth redirect could potentially craft malicious URLs. - Fix: Validate URL format/scheme before passing to exec.Command().
URL schemes are case-insensitive per RFC 3986, but the comparison was case-sensitive, rejecting valid URLs like "HTTP://..." or "Https://...". Normalize with strings.ToLower before comparing. Extract validateBrowserURL so the validation logic can be unit-tested without launching a browser. Add 12 table-driven tests covering: valid http/https, uppercase and mixed-case schemes, and rejected schemes (file, javascript, custom, ftp, empty, missing, malformed). Co-Authored-By: Claude Opus 4.5 <[email protected]>
wesm
force-pushed
the
bug-command-injection
branch
from
e09489c to
989ef5f
Compare
wesm
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.