Conversation
…cy comments Address robustness findings from security review: - Split oversized comments to stay under GitHub's 65K char limit - Post new comment before deleting old ones so context is never lost - Clean up legacy inline review comments in addition to issue comments - Add 15 unit tests covering size splitting, ordering, and edge cases Co-Authored-By: Claude Opus 4.6 <[email protected]>
…urity bot Address robustness review findings: - Prevent self-deletion: track new comment IDs and pass exclude_ids to delete_old_bot_comments so freshly posted comments aren't removed - Handle oversized single sections: add hard-wrap fallback with min_cut guarantee to split any chunk exceeding 60K, even without --- separators - Add HTML bot marker (<!-- msgvault-security-bot -->) to all comments including split continuation chunks for reliable cleanup matching - Add 24 tests including integration tests with FakePR verifying real post-then-delete behavior and self-deletion prevention Co-Authored-By: Claude Opus 4.6 <[email protected]>
Assert that every posted chunk is <= 60K chars in all split/hard-wrap tests, closing a testing gap that could let off-by-one regressions in chunk sizing slip through. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Drop the get_review_comments() cleanup logic — deleting old inline review comments from a previous bot format is too aggressive. Only clean up issue comments going forward. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_idsso the cleanup pass doesn't delete the comment it just posted<!-- msgvault-security-bot -->HTML comment in every bot comment (including split continuation chunks) for reliable cleanup matchingTest plan
pytest test_security_review.py)make test)🤖 Generated with Claude Code