Repository navigation
Commit b45b4ee
committed
fix(cli): count post-suppression findings in recursive multi-skill report
The recursive summary table and combined JSON report computed finding_count as
`filtered_findings or findings`, which falls through to the unfiltered findings
when suppression empties filtered_findings, since an empty list is falsy. A fully
baselined sub-skill then showed score 0 but a non-zero finding_count.
Add _result_finding_count(), which falls back to raw findings only when
filtered_findings is absent (the report node always sets it, possibly empty after
suppression), and use it at both the summary table and the combined JSON report.
Add a regression test asserting the combined JSON finding_count is 0 for a fully
suppressed sub-skill.
Surfaced by an independent review of NVIDIA#205.
Refs NVIDIA#201
Signed-off-by: Werner Kasselman <[email protected]>1 parent 3511351 commit b45b4ee
2 files changed
Lines changed: 67 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
368 | 383 | | |
369 | 384 | | |
370 | 385 | | |
| |||
419 | 434 | | |
420 | 435 | | |
421 | 436 | | |
422 | | - | |
423 | | - | |
| 437 | + | |
424 | 438 | | |
425 | 439 | | |
426 | 440 | | |
| |||
442 | 456 | | |
443 | 457 | | |
444 | 458 | | |
445 | | - | |
446 | | - | |
447 | | - | |
| 459 | + | |
448 | 460 | | |
449 | 461 | | |
450 | 462 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
0 commit comments