Repository navigation
Conversation
) - Rename `json_dump` to `json_dumps` across `dmr.openapi.dump` and `dmr.internal.json` - Update `OpenAPIJsonView` and test client to use `json_dumps` - Retain `json_dump = json_dumps` alias for backwards compatibility - Add unit tests in `tests/test_unit/test_openapi/test_dump.py` - Document breaking change in `CHANGELOG.md`
sobolevn
reviewed
Sep 4, 2026
|
|
||
|
|
||
| # Deprecated alias for backwards compatibility: | ||
| json_dump = json_dumps |
Member
There was a problem hiding this comment.
nope, we don't need an alias. this is an internal structure. we prefer to break things while in alpha.
|
|
||
|
|
||
| # Deprecated alias for backwards compatibility: | ||
| json_dump = json_dumps |
| @@ -0,0 +1,27 @@ | |||
| import json | |||
|
|
|||
| from dmr.internal.json import json_dump as internal_json_dump | |||
Contributor
Author
|
Makes complete sense since we're in alpha. Dropped the json_dump aliases from dmr/internal/json.py and dmr/openapi/dump.py, and removed the redundant alias test file. Ran the full unit test suite (all 2,171 tests pass) and linters are all green. |
sobolevn
approved these changes
Sep 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 467 467
Lines 21639 21639
Branches 660 660
=========================================
Hits 21639 21639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
AI Policy
Checklist
Related issues
Closes #1399
Changes
json_dumptojson_dumpsindmr.internal.jsonanddmr.openapi.dumpto adhere to standard Pythonjson.dumpsstring-serialization conventionsOpenAPIJsonViewand test client to calljson_dumpsjson_dump = json_dumpsfor backwards compatibilitytests/test_unit/test_openapi/test_dump.pyCHANGELOG.mdunder0.15.0 WIP