Print missing language extensions on TH generation of labels#352
Print missing language extensions on TH generation of labels#352
Conversation
1321e88 to
b9a1566
Compare
adamgundry
left a comment
There was a problem hiding this comment.
@arybczak Lovely! Thanks for taking care of this. A couple of minor suggestions in addition to the review comments:
makeFieldscould have arequireExtensionscall.- I'm slightly tempted to include the list of required extensions explicitly in the haddocks.
I wanted to do that, the problem is that its need for |
There are 7 variations for functions that generate labels ( |
|
|
941bb75 to
95efe25
Compare
|
Fair enough, I added check for |
|
Though |
95efe25 to
501772d
Compare
|
I made it require both. HLint will not complain about redundant pragmas because it can't inspect TH. |
It may for users who copy-paste the |
|
I'm okay with this. A slight over-approximation to the required extensions seems relatively unproblematic, although it might conceivably result in users needing to enable additional extensions on a working build. And fair enough regarding docs. |
Fixes #342.