If torrent is not private, leave private flag unset - #1411
Merged
Conversation
If torrent is not private, leave private flag unset. This ensures that the torrent info hash will match the result generated by other tools, including webtorrent-cli.
DiegoRBaquero
approved these changes
May 25, 2018
DiegoRBaquero
left a comment
DiegoRBaquero
left a comment
Member
There was a problem hiding this comment.
Makes sense to leave it unset rather than changing the others to setting it to false. It's unneeded info in the torrent tbh.
codealchemist
approved these changes
May 25, 2018
codealchemist
left a comment
codealchemist
left a comment
Contributor
There was a problem hiding this comment.
Makes sense and the change is looking good.
Thanks!
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If torrent is not private, leave private flag unset. This ensures that the torrent info hash will match the result generated by other tools, including
webtorrent-cli.Fixes: https://github.com/webtorrent/webtorrent-hybrid/issues/79
More info:
WebTorrent Desktop uses the result of the "Private" checkbox at torrent creation time to set the torrent's
privateflag totrueorfalse. Unfortunately, there's an issue with the way thisprivateflag spec was designed. There are actually 3 possible values for theprivateflag:private: trueprivate: falsefalse)The problem is that
privateflag is part of theinfosection in the .torrent file, which means that each of these three values forprivatewill produce a different info hash.So, what's happening is that
webtorrent-cliandwebtorrent-hybridare not settingprivateat all, while WebTorrent Desktop is setting it tofalse.We should either set it to
trueor leave it not specified to match whatwebtorrent-cli,webtorrent-hybrid, and other mainstream torrent clients do.