[fix] Do not prematurely remove the listener of the 'data' event

lpinca · lpinca · commit 6046a2873944 · 2018-06-19T22:49:42.000+02:00
diff --git a/lib/websocket.js b/lib/websocket.js
@@ -750,7 +750,6 @@ function socketOnClose () {
   const websocket = this[kWebSocket];
 
   this.removeListener('close', socketOnClose);
-  this.removeListener('data', socketOnData);
   this.removeListener('end', socketOnEnd);
   this[kWebSocket] = undefined;
 
@@ -760,11 +759,16 @@ function socketOnClose () {
   // The close frame might not have been received or the `'end'` event emitted,
   // for example, if the socket was destroyed due to an error. Ensure that the
   // `receiver` stream is closed after writing any remaining buffered data to
-  // it.
+  // it. If the readable side of the socket is in flowing mode then there is no
+  // buffered data as everything has been already written and `readable.read()`
+  // will return `null`. If instead, the socket is paused, any possible buffered
+  // data will be read as a single chunk and emitted synchronously in a single
+  // `'data'` event.
   //
   websocket._socket.read();
   websocket._receiver.end();
 
+  this.removeListener('data', socketOnData);
   clearTimeout(websocket._closeTimer);
 
   if (
