Add support for Prettier overrides#1869
Merged
Merged
Conversation
Prettier overrides may define plugins in addition to the top-level config.
commit: |
webpro
reviewed
Jul 6, 2026
webpro
left a comment
webpro
left a comment
Member
There was a problem hiding this comment.
Thanks for the pull request! Happy to merge, just one non-blocking nit.
| if (Array.isArray(options.plugins)) { | ||
| for (const plugin of options.plugins) { | ||
| if (typeof plugin === 'string') { | ||
| result.add(toDependency(plugin)); |
Member
There was a problem hiding this comment.
Bit of a minor thing, but Input is an object so using a Set does not dedupe here.
Contributor
Author
There was a problem hiding this comment.
Right, that makes sense. Does deduplication even matter? It felt like the clean approach, but it probably doesn’t matter at all.
Member
There was a problem hiding this comment.
Eventually Knip itself dedupes. Anyway let's roll with it.
Member
|
🚀 This pull request is included in v6.25.0. See Release 6.25.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier overrides may define plugins in addition to the top-level config.