Fix Bun test defaults#1860
Merged
Merged
Conversation
commit: |
Member
|
Thanks Jake! I think I'm just going to merge this one and then revisit both Node.js and Bun plugins and apply a more consistent approach as each has its own pros/cons. The fixtures should prevent regressions. |
Member
|
Just pushed a bunch of refactors around this, feel free to review and/or try it out. Planning to release main tomorrow. |
Member
|
🚀 This pull request is included in v6.25.0. See Release 6.25.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun testscriptsbun testscripts with options beforetest, such asbun --config=... test*.test.tsand*.test.tsxfiles are treated as entriesbundependency when the Bun plugin provides defaultsValidation
bun test test/plugins/bun.test.ts test/plugins/bun2.test.ts test/plugins/bun3.test.ts test/plugins/bun4.test.ts test/plugins/bun5.test.ts test/plugins/bun6.test.ts test/plugins/bun7.test.tspnpm buildpnpm test --runtime bun --smokebun.entryworkaround removed via a temporary config: patched Knip no longer reports colocated test files as unused, and no longer reports the rootbundevDependency as unused