Skip to content

feat: add scss handling to stencil plugin#1846

Merged
webpro merged 3 commits into
webpro-nl:mainfrom
johnjenkins:feat-stencil-scss-handling
Jul 1, 2026
Merged

feat: add scss handling to stencil plugin#1846
webpro merged 3 commits into
webpro-nl:mainfrom
johnjenkins:feat-stencil-scss-handling

Conversation

@johnjenkins

Copy link
Copy Markdown
Contributor

👋 again!

Thanks so much for the recent improvements on the Stencil plugin 🙂

I thought I would add scss participation too via @stencil/sass (but will also catch false-positives incase someone has an explicit sass dep)

@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/knip@1846
npm i https://pkg.pr.new/@knip/language-server@1846
npm i https://pkg.pr.new/@knip/mcp@1846

commit: 661ddd5

@webpro webpro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool PR! Nice seeing this come to fruition after enabling it 🥳 Just a few minor remarks and we're good.

Comment thread packages/knip/fixtures/plugins/stencil/src/components/my-card.tsx
Comment thread packages/knip/src/plugins/stencil/index.ts Outdated
Comment thread packages/knip/src/plugins/stencil/index.ts Outdated
@webpro
webpro merged commit acba6b8 into webpro-nl:main Jul 1, 2026
30 checks passed
@webpro

webpro commented Jul 1, 2026

Copy link
Copy Markdown
Member

Thanks John! 💫

@webpro

webpro commented Jul 2, 2026

Copy link
Copy Markdown
Member

🚀 This pull request is included in v6.24.0. See Release 6.24.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants