fix: remove format_on_save: true settings from Zed settings to respect user settings#1838
Merged
webpro merged 1 commit intoJun 29, 2026
Conversation
…t user settings Co-authored-by: Fabian Iwand <[email protected]>
commit: |
Member
|
🚀 This pull request is included in v6.24.0. See Release 6.24.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks to @mootari for mentioning on Discord that the
format_on_saveoption should ideally not be overridden in our projects Zed settings, so users can experience it in the way the want.Since we'll probably add pre-commit hooks in #1837 anyway, it doesn't really matter if the user always formats when saving the files 👍