feat: add support for @astrojs/markdoc#1829
Merged
Merged
Conversation
commit: |
webpro
reviewed
Jun 27, 2026
webpro
left a comment
webpro
left a comment
Member
There was a problem hiding this comment.
Thanks for another plugin! 🥳 Just a few nits left.
Co-authored-by: Lars Kappert <[email protected]>
Contributor
Author
|
I fixed our suggestions and also added a second parameter to the |
Member
|
Thanks! 🚀 |
Member
|
🚀 This pull request is included in v6.23.0. See Release 6.23.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a new Knip plugin for the
@astrojs/markdocpackage.Astro's Markdoc integration offers a configuration file, which references Astro components via the
renderproperty (innodesandtags). The plugin resolves all those paths, so the Knip analysis graph can be constructed.I decided to add the
astrodep in the fixture as it is a peerDep from@astrojs/markdoc.I added the config file as a default production entry, because of this tip:
However, I remember reading somewhere that config files should never be entries (not sure if I am misremembering), so I wanted to mention it here to hopefully make reviewing the PR easier.
This PR should also enable auto-detection for users of
@astrojs/starlight-markdoc, as that package has@astrojs/markdocas a peerDep, so they need to install it either way 🙌